Re: [PATCH] ASoC: tas2562: Fixed incorrect amp_level setting.

[Dan Murphy]

Jonghwan

On 3/19/20 9:00 AM, Jonghwan Choi wrote:
> According to the tas2562 datasheet,the bits[5:1] represents the amp_level value.
> So to set the amp_level value correctly,the shift value should be set to 1.
>
> Signed-off-by: Jonghwan Choi <charlie.jh@xxxxxxxxxxxxx>
> ---
>   sound/soc/codecs/tas2562.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/sound/soc/codecs/tas2562.c b/sound/soc/codecs/tas2562.c
> index be52886a5edb..fb2233ca9103 100644
> --- a/sound/soc/codecs/tas2562.c
> +++ b/sound/soc/codecs/tas2562.c
> @@ -409,7 +409,7 @@ static const struct snd_kcontrol_new vsense_switch =
>   			1, 1);
>   
>   static const struct snd_kcontrol_new tas2562_snd_controls[] = {
> -	SOC_SINGLE_TLV("Amp Gain Volume", TAS2562_PB_CFG1, 0, 0x1c, 0,
> +	SOC_SINGLE_TLV("Amp Gain Volume", TAS2562_PB_CFG1, 1, 0x1c, 0,
>   		       tas2562_dac_tlv),
>   };
>   


Acked-by: Dan Murphy <dmurphy@xxxxxx>