Re: [PATCH 5.5 01/65] gpiolib: Add support for the irqdomain which doesnt use irq_fwspec as arg

From: Greg Kroah-Hartman
Date: Thu Mar 19 2020 - 09:47:36 EST


On Thu, Mar 19, 2020 at 09:33:55PM +0800, Kevin Hao wrote:
> On Thu, Mar 19, 2020 at 02:03:43PM +0100, Greg Kroah-Hartman wrote:
> > From: Kevin Hao <haokexin@xxxxxxxxx>
> >
> > [ Upstream commit 242587616710576808dc8d7cdf18cfe0d7bf9831 ]
> >
> > Some gpio's parent irqdomain may not use the struct irq_fwspec as
> > argument, such as msi irqdomain. So rename the callback
> > populate_parent_fwspec() to populate_parent_alloc_arg() and make it
> > allocate and populate the specific struct which is needed by the
> > parent irqdomain.
>
> Hi Greg,
>
> This commit shouldn't go to stable because it is not a bug fix. It is just a
> prerequisite of switching to general GPIOLIB_IRQCHIP for thunderx gpio driver
> (commit 7a9f4460f74d "gpio: thunderx: Switch to GPIOLIB_IRQCHIP").

This seems to be a prerequisite for f98371476f36 ("pinctrl: qcom:
ssbi-gpio: Fix fwspec parsing bug") to apply properly. With that
information, is it ok to keep?

thanks,

greg k-h