Re: [PATCH] thermal: imx_sc_thermal: Fix incorrect data type

From: Daniel Lezcano
Date: Thu Mar 19 2020 - 07:56:00 EST


On 19/03/2020 09:26, Anson Huang wrote:
> The temperature value passed from SCU could be negative value,
> the data type should be signed instead of unsigned.
>
> Fixes: ed0843633fee ("thermal: imx_sc: add i.MX system controller thermal support")
> Signed-off-by: Anson Huang <Anson.Huang@xxxxxxx>

Applied, thanks

> ---
> drivers/thermal/imx_sc_thermal.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/thermal/imx_sc_thermal.c b/drivers/thermal/imx_sc_thermal.c
> index dbb277a..a8723b1 100644
> --- a/drivers/thermal/imx_sc_thermal.c
> +++ b/drivers/thermal/imx_sc_thermal.c
> @@ -30,8 +30,8 @@ struct req_get_temp {
> } __packed __aligned(4);
>
> struct resp_get_temp {
> - u16 celsius;
> - u8 tenths;
> + s16 celsius;
> + s8 tenths;
> } __packed __aligned(4);
>
> struct imx_sc_msg_misc_get_temp {
>


--
<http://www.linaro.org/> Linaro.org â Open source software for ARM SoCs

Follow Linaro: <http://www.facebook.com/pages/Linaro> Facebook |
<http://twitter.com/#!/linaroorg> Twitter |
<http://www.linaro.org/linaro-blog/> Blog