Re: [PATCH v2] irqchip/versatile-fpga: Handle chained IRQs properly

From: Marc Zyngier
Date: Thu Mar 19 2020 - 04:45:03 EST


On 2020-03-19 02:34, Sungbo Eo wrote:
Enclose the chained handler with chained_irq_{enter,exit}(), so that the
muxed interrupts get properly acked.

This patch also fixes a reboot bug on OX820 SoC, where the jiffies timer
interrupt is never acked. The kernel waits a clock tick forever in
calibrate_delay_converge(), which leads to a boot hang.

Fixes: c41b16f8c9d9 ("ARM: integrator/versatile: consolidate FPGA IRQ
handling code")
Signed-off-by: Sungbo Eo <mans0n@xxxxxxxxxx>
Cc: Neil Armstrong <narmstrong@xxxxxxxxxxxx>
---
v2: moved readl below chained_irq_enter()
added Fixes tag

drivers/irqchip/irq-versatile-fpga.c | 12 ++++++++++--
1 file changed, 10 insertions(+), 2 deletions(-)

Queued for 5.7.

Thanks,

M.
--
Jazz is not dead. It just smells funny...