Re: [PATCH v5 2/3] perf vendor events amd: add Zen2 events

From: Arnaldo Carvalho de Melo
Date: Wed Mar 18 2020 - 11:52:51 EST


Em Wed, Mar 18, 2020 at 11:21:12AM -0400, Vijay Thakkar escreveu:
> > floating point:
> > fpu_pipe_assignment.total
> > [Total number of fp uOps]
> >
> >
> > Metric Groups:
> >
>
> I just realized that I did not add back the counters for per pipe total
> assignment as I said in the commit message. Patch 3/3 adds the total
> uOp assignments per pipe for Zen1 based processors. Although the PPR for
> Matisse does not list these counters, I can still sample them on my
> Ryzen 3900X system and they seem to report correct numbers. For example,
> here is the result of running:
>
> $> perf stat -e r100,r200,r400,r800,rf00 ls
>
> $> Performance counter stats for 'ls':
>
> 5,047 r100:u
> 5,236 r200:u
> 31,300 r400:u
> 2,040 r800:u
> 43,623 fpu_pipe_assignment.total:u
>
> Note that the per pipe total counters add up the overall total, which
> makes me think I should submit a v6 of this patch adding the per pipe
> totals for zen2 as well, especially since it is mentioned in the commit
> message.

Ok, so I'll remove these patches, please redo that sequence I did in the
commit log, ok?

- Arnaldo