Re: [PATCH 12/15] powerpc/watchpoint: Prepare handler to handle more than one watcnhpoint

From: Christophe Leroy
Date: Wed Mar 18 2020 - 07:44:59 EST




Le 18/03/2020 Ã 12:35, Michael Ellerman a ÃcritÂ:
Christophe Leroy <christophe.leroy@xxxxxx> writes:
Le 09/03/2020 Ã 09:58, Ravi Bangoria a ÃcritÂ:
Currently we assume that we have only one watchpoint supported by hw.
Get rid of that assumption and use dynamic loop instead. This should
make supporting more watchpoints very easy.

I think using 'we' is to be avoided in commit message.

Hmm, is it?

I use 'we' all the time. Which doesn't mean it's correct, but I think it
reads OK.

cheers


From https://www.kernel.org/doc/html/latest/process/submitting-patches.html :

Describe your changes in imperative mood, e.g. âmake xyzzy do frotzâ instead of â[This patch] makes xyzzy do frotzâ or â[I] changed xyzzy to do frotzâ, as if you are giving orders to the codebase to change its behaviour.

Christophe