Re: [PATCH] KVM: nVMX: remove side effects from nested_vmx_exit_reflected

From: Paolo Bonzini
Date: Wed Mar 18 2020 - 06:59:22 EST


On 18/03/20 11:52, Vitaly Kuznetsov wrote:
> The only functional difference seems to be that we're now doing
> nested_mark_vmcs12_pages_dirty() in vmx->fail case too and this seems
> superfluous: we failed to enter L2 so 'special' pages should remain
> intact (right?) but this should be an uncommon case.
>
> Reviewed-by: Vitaly Kuznetsov <vkuznets@xxxxxxxxxx>

I'm not entirely sure if the PID could be written before the processor
decrees a vmfail. It doesn't really hurt anyway as you say though.
Thanks for the review!

Paolo