Re: [PATCH v3] thermal: devfreq_cooling: Use PM QoS to set frequency limits

From: Lukasz Luba
Date: Wed Mar 18 2020 - 04:07:58 EST


Hi Daniel, Rui,

On 3/13/20 4:55 PM, Matthias Kaehlcke wrote:
On Thu, Mar 12, 2020 at 11:34:20AM -0700, Matthias Kaehlcke wrote:
Now that devfreq supports limiting the frequency range of a device
through PM QoS make use of it instead of disabling OPPs that should
not be used.

The switch from disabling OPPs to PM QoS introduces a subtle behavioral
change in case of conflicting requests (min > max): PM QoS gives
precedence to the MIN_FREQUENCY request, while higher OPPs disabled
with dev_pm_opp_disable() would override MIN_FREQUENCY.

Signed-off-by: Matthias Kaehlcke <mka@xxxxxxxxxxxx>
Reviewed-by: Lukasz Luba <lukasz.luba@xxxxxxx>

I just noticed that I forgot to add Chanwoo's 'Reviewed-by' tag from v2.
Dunno if patchwork will allow this, but I can try:

Reviewed-by: Chanwoo Choi <cw00.choi@xxxxxxxxxxx>


Could you apply this patch, please? I would like to send the new Energy
Model and the devfreq cooling changes would be based on this.

Regards,
Lukasz