Re: [PATCH 03/15] powerpc/watchpoint: Introduce function to get nr watchpoints dynamically

[Ravi Bangoria]

> > diff --git a/arch/powerpc/include/asm/hw_breakpoint.h b/arch/powerpc/include/asm/hw_breakpoint.h
> > index f2f8d8aa8e3b..741c4f7573c4 100644
> > --- a/arch/powerpc/include/asm/hw_breakpoint.h
> > +++ b/arch/powerpc/include/asm/hw_breakpoint.h
> > @@ -43,6 +43,8 @@ struct arch_hw_breakpoint {
> > Â #define DABR_MAX_LENÂÂÂ 8
> > Â #define DAWR_MAX_LENÂÂÂ 512
> > +extern int nr_wp_slots(void);
>
> 'extern' keyword is unneeded and irrelevant here. Please remove it. Even checkpatch is unhappy (https://openpower.xyz/job/snowpatch/job/snowpatch-linux-checkpatch/12172//artifact/linux/checkpatch.log)

Sure.

...
> > diff --git a/arch/powerpc/kernel/process.c b/arch/powerpc/kernel/process.c
> > index 110db94cdf3c..6d4b029532e2 100644
> > --- a/arch/powerpc/kernel/process.c
> > +++ b/arch/powerpc/kernel/process.c
> > @@ -835,6 +835,12 @@ static inline bool hw_brk_match(struct arch_hw_breakpoint *a,
> > ÂÂÂÂÂ return true;
> > Â }
> > +/* Returns total number of data breakpoints available. */
> > +int nr_wp_slots(void)
> > +{
> > +ÂÂÂ return HBP_NUM_MAX;
> > +}
> > +
>
> This is not worth a global function. At least it should be a static function located in hw_breakpoint.c. But it would be even better to have it as a static inline in asm/hw_breakpoint.h

Makes sense. Will change it.

Thanks.