Re: [PATCH 01/10] KVM: nVMX: Move reflection check into nested_vmx_reflect_vmexit()

From: Sean Christopherson
Date: Tue Mar 17 2020 - 14:01:51 EST


On Tue, Mar 17, 2020 at 06:38:20PM +0100, Paolo Bonzini wrote:
> On 17/03/20 18:00, Vitaly Kuznetsov wrote:
> >
> > On the other hand, I'm a great fan of splitting checkers ('pure'
> > functions) from actors (functions with 'side-effects') and
> > nested_vmx_exit_reflected() while looking like a checker does a lot of
> > 'acting': nested_mark_vmcs12_pages_dirty(), trace printk.
>
> Good idea (trace_printk is not a big deal, but
> nested_mark_vmcs12_pages_dirty should be done outside). I'll send a
> patch, just to show that I can still write KVM code. :)

LOL, don't jinx yourself.