Re: [PATCH 06/10] KVM: nVMX: Convert local exit_reason to u16 in ...enter_non_root_mode()

From: Paolo Bonzini
Date: Tue Mar 17 2020 - 13:40:46 EST


On 17/03/20 06:29, Sean Christopherson wrote:
>>>
>>> load_vmcs12_host_state(vcpu, vmcs12);
>>> - vmcs12->vm_exit_reason = exit_reason | VMX_EXIT_REASONS_FAILED_VMENTRY;
>>> + vmcs12->vm_exit_reason = VMX_EXIT_REASONS_FAILED_VMENTRY | exit_reason;
>> My personal preference would be to do
>> (u32)exit_reason | VMX_EXIT_REASONS_FAILED_VMENTRY
>> instead but maybe I'm just not in love with implicit type convertion in C.
> Either way works for me. Paolo?
>

Flip a coin? :) I think your version is fine.

Paolo