Re: [v2 PATCH 1/2] mm: swap: make page_evictable() inline

From: kbuild test robot
Date: Mon Mar 16 2020 - 23:16:16 EST


Hi Yang,

Thank you for the patch! Yet something to improve:

[auto build test ERROR on mmotm/master]
[also build test ERROR on linus/master v5.6-rc6 next-20200316]
[if your patch is applied to the wrong git tree, please drop us a note to help
improve the system. BTW, we also suggest to use '--base' option to specify the
base tree in git format-patch, please see https://stackoverflow.com/a/37406982]

url: https://github.com/0day-ci/linux/commits/Yang-Shi/mm-swap-make-page_evictable-inline/20200317-094836
base: git://git.cmpxchg.org/linux-mmotm.git master
config: openrisc-simple_smp_defconfig (attached as .config)
compiler: or1k-linux-gcc (GCC) 9.2.0
reproduce:
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
# save the attached .config to linux build tree
GCC_VERSION=9.2.0 make.cross ARCH=openrisc

If you fix the issue, kindly add following tag
Reported-by: kbuild test robot <lkp@xxxxxxxxx>

All errors (new ones prefixed by >>):

In file included from include/linux/suspend.h:5,
from init/do_mounts.c:7:
include/linux/swap.h: In function 'page_evictable':
include/linux/swap.h:395:9: error: implicit declaration of function 'mapping_unevictable'; did you mean 'mapping_deny_writable'? [-Werror=implicit-function-declaration]
395 | ret = !mapping_unevictable(page_mapping(page)) && !PageMlocked(page);
| ^~~~~~~~~~~~~~~~~~~
| mapping_deny_writable
In file included from include/linux/mempolicy.h:16,
from include/linux/shmem_fs.h:7,
from init/do_mounts.c:21:
include/linux/pagemap.h: At top level:
>> include/linux/pagemap.h:73:20: error: conflicting types for 'mapping_unevictable'
73 | static inline bool mapping_unevictable(struct address_space *mapping)
| ^~~~~~~~~~~~~~~~~~~
In file included from include/linux/suspend.h:5,
from init/do_mounts.c:7:
include/linux/swap.h:395:9: note: previous implicit declaration of 'mapping_unevictable' was here
395 | ret = !mapping_unevictable(page_mapping(page)) && !PageMlocked(page);
| ^~~~~~~~~~~~~~~~~~~
cc1: some warnings being treated as errors

vim +/mapping_unevictable +73 include/linux/pagemap.h

72
> 73 static inline bool mapping_unevictable(struct address_space *mapping)
74 {
75 if (mapping)
76 return test_bit(AS_UNEVICTABLE, &mapping->flags);
77 return !!mapping;
78 }
79

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@xxxxxxxxxxxx

Attachment: .config.gz
Description: application/gzip