Re: [PATCH v5 2/2] mm/sparse.c: allocate memmap preferring the given node

From: Wei Yang
Date: Mon Mar 16 2020 - 18:16:55 EST


On Mon, Mar 16, 2020 at 08:56:25PM +0800, Baoquan He wrote:
>When allocating memmap for hot added memory with the classic sparse, the
>specified 'nid' is ignored in populate_section_memmap().
>
>While in allocating memmap for the classic sparse during boot, the node
>given by 'nid' is preferred. And VMEMMAP prefers the node of 'nid' in
>both boot stage and memory hot adding. So seems no reason to not respect
>the node of 'nid' for the classic sparse when hot adding memory.
>
>Use kvmalloc_node instead to use the passed in 'nid'.
>
>Signed-off-by: Baoquan He <bhe@xxxxxxxxxx>
>Acked-by: Michal Hocko <mhocko@xxxxxxxx>
>Reviewed-by: Matthew Wilcox (Oracle) <willy@xxxxxxxxxxxxx>

Reviewed-by: Wei Yang <richard.weiyang@xxxxxxxxx>


--
Wei Yang
Help you, Help me