Re: [PATCH v4 2/3] perf vendor events amd: add Zen2 events

From: Kim Phillips
Date: Mon Mar 16 2020 - 17:52:01 EST


On 3/13/20 11:44 PM, Vijay Thakkar wrote:
> Signed-off-by: Vijay Thakkar <vijaythakkar@xxxxxx>

This email address differs from patch 1/3's S-o-b:

Signed-off-by: thakkarv <thakkarv@xxxxxxxxxx>

Choose one, and please spell your whole name out - Vijay Thakkar.

> +++ b/tools/perf/pmu-events/arch/x86/amdzen2/branch.json
> @@ -0,0 +1,52 @@
> +[
> + {
> + "EventName": "bp_l1_btb_correct",
> + "EventCode": "0x8a",
> + "BriefDescription": "[L1 Branch Prediction Overrides Existing Prediction (speculative)."

Remove the leading '[' in the BriefDescription string.

Other than the above two nit picks:

Acked-by: Kim Phillips <kim.phillips@xxxxxxx>

Thanks,

Kim