Re: [PATCHv2 01/50] kallsyms/printk: Add loglvl to print_ip_sym()

From: Joe Perches
Date: Mon Mar 16 2020 - 11:31:23 EST


On Mon, 2020-03-16 at 14:38 +0000, Dmitry Safonov wrote:
> print_ip_sym() needs to have a log level parameter to comply with other
> parts being printed. Otherwise, half of the expected backtrace would be
> printed and other may be missing with some logging level.

There are 15 instances of print_ip_sym.

Perhaps it'd be better to get rid of print_ip_sym
altogether by expanding it in-place instead.

> arch/microblaze/kernel/unwind.c | 2 +-
> arch/mips/kernel/traps.c | 4 ++--
> arch/nds32/kernel/traps.c | 4 ++--
> arch/riscv/kernel/stacktrace.c | 2 +-
> include/linux/kallsyms.h | 4 ++--
> kernel/locking/lockdep.c | 4 ++--
> kernel/sched/core.c | 6 ++----
> kernel/trace/ftrace.c | 8 ++++----
> tools/include/linux/kallsyms.h | 2 +-