Re: [PATCH] kthread: Mark timer used by delayed kthread works as IRQ safe

[Grygorii Strashko]

Hi Petr,

On 19/02/2020 17:22, Tejun Heo wrote:
> On Mon, Feb 17, 2020 at 01:07:09PM +0100, Petr Mladek wrote:
> > The timer used by delayed kthread works are IRQ safe because the used
> > kthread_delayed_work_timer_fn() is IRQ safe.
> >
> > It is properly marked when initialized by KTHREAD_DELAYED_WORK_INIT().
> > But TIMER_IRQSAFE flag is missing when initialized by
> > kthread_init_delayed_work().
> >
> > The missing flag might trigger invalid warning from del_timer_sync()
> > when kthread_mod_delayed_work() is called with interrupts disabled.
> >
> > Reported-by: Grygorii Strashko <grygorii.strashko@xxxxxx>
> > Signed-off-by: Petr Mladek <pmladek@xxxxxxxx>
> > Tested-by: Grygorii Strashko <grygorii.strashko@xxxxxx>
>
> Acked-by: Tejun Heo <tj@xxxxxxxxxx>

I'm worry shouldn't this patch have "fixes" tag?

--
Best regards,
grygorii