Re: [PATCH v4 2/4] power_supply: Add additional health properties to the header

[Dan Murphy]

Hello

On 3/6/20 5:55 PM, Sandeep Patil wrote:
> Hi Sebastian,
>
> On Fri, Jan 17, 2020 at 02:06:58AM +0100, Sebastian Reichel wrote:
> > Hi,
> >
> > On Thu, Jan 16, 2020 at 11:50:37AM -0600, Dan Murphy wrote:
> > > Add HEALTH_WARM, HEALTH_COOL and HEALTH_HOT to the health enum.
> > >
> > > Signed-off-by: Dan Murphy <dmurphy@xxxxxx>
> > > ---
> > Looks good. But I will not merge it without a user and have comments
> > for the driver.
> Android has been looking for these properties for a while now [1].
> It was added[2] when we saw that the manufacturers were implementing these
> properties in the driver. I didn't know the properties were absent upstream
> until yesterday. Somebody pointed out in our ongoing effort to make sure
> all core kernel changes that android depends on are present upstream.
>
> I think those values are also propagated in application facing APIs in
> Android (but I am not sure yet, let me know if that's something you want
> to find out).
>
> I wanted to chime in and present you a 'user' for this if that helps.

We have re-submitted the BQ25150/155 driver that would be the user and 
we have 2 more for review that will use the new definitions

Dan