Re: [PATCH] net: hns3: remove redundant initialization of pointer 'client'

From: David Miller
Date: Sun Feb 23 2020 - 20:27:13 EST


From: Colin King <colin.king@xxxxxxxxxxxxx>
Date: Sat, 22 Feb 2020 19:52:31 +0000

> @@ -9076,7 +9076,7 @@ static int hclge_init_nic_client_instance(struct hnae3_ae_dev *ae_dev,
> static int hclge_init_roce_client_instance(struct hnae3_ae_dev *ae_dev,
> struct hclge_vport *vport)
> {
> - struct hnae3_client *client = vport->roce.client;
> + struct hnae3_client *client;
> struct hclge_dev *hdev = ae_dev->priv;
> int rst_cnt;
> int ret;

Please preserve the reverse christmas tree ordering of local variables when
you make changes like this.