RE: [PATCH RESEND v3 4/4] scsi: ufs-mediatek: gate ref-clk during Auto-Hibern8

From: Stanley Chu
Date: Fri Jan 31 2020 - 20:46:36 EST


Hi Avri,

On Fri, 2020-01-31 at 18:48 +0000, Avri Altman wrote:
> >
> > +static u32 ufs_mtk_link_get_state(struct ufs_hba *hba)
> > +{
> > + u32 val;
> > +
> > + ufshcd_writel(hba, 0x20, REG_UFS_DEBUG_SEL);
> > + val = ufshcd_readl(hba, REG_UFS_PROBE);
> > + val = val >> 28;
> > +
> > + return val;
> > +}
> A little bit strange that you are relying on debug registers to setup your ref-clock.
> Is this this debug info is always available?
>

Yes, this register is only for this purpose now (query link state) and
always existed in MediaTek UFS host.

Thanks,
Stanley