Re: [PATCH v3 3/5] OPP: Improve require-opps linking

From: Viresh Kumar
Date: Wed Jan 29 2020 - 23:21:33 EST


On 29-01-20, 19:04, Sibi Sankar wrote:
> I don't have a gen-pd use case to test against but with the is_genpd
> check removed it works as expected when I used it against this
> series: https://patchwork.kernel.org/cover/11353185/
>
> In the lazy_link_required_opps fn shouldn't we skip the dynamic
> opps in the the opp list?

Tables with dynamic OPPs should not be there in pending_opp_tables
list and so that function shall never get called for them.

> With ^^ addressed:
> Reviewed-by: Sibi Sankar <sibis@xxxxxxxxxxxxxx>
> Tested-by: Sibi Sankar <sibis@xxxxxxxxxxxxxx>

Thanks Sibi.

@Saravana: Can you please give your feedback as well? I don't want to
push something that may end up breaking something else :)

--
viresh