Re: [PATCH] powerpc/process: Remove unneccessary #ifdef CONFIG_PPC64 in copy_thread_tls()

From: Michal Suchánek
Date: Wed Jan 29 2020 - 16:05:49 EST


On Wed, Jan 29, 2020 at 07:50:07PM +0000, Christophe Leroy wrote:
> is_32bit_task() exists on both PPC64 and PPC32, no need of an ifdefery.
>
> Signed-off-by: Christophe Leroy <christophe.leroy@xxxxxx>
> ---
> arch/powerpc/kernel/process.c | 2 --
> 1 file changed, 2 deletions(-)
>
> diff --git a/arch/powerpc/kernel/process.c b/arch/powerpc/kernel/process.c
> index fad50db9dcf2..e730b8e522b0 100644
> --- a/arch/powerpc/kernel/process.c
> +++ b/arch/powerpc/kernel/process.c
> @@ -1634,11 +1634,9 @@ int copy_thread_tls(unsigned long clone_flags, unsigned long usp,
> p->thread.regs = childregs;
> childregs->gpr[3] = 0; /* Result from fork() */
> if (clone_flags & CLONE_SETTLS) {
> -#ifdef CONFIG_PPC64
> if (!is_32bit_task())
> childregs->gpr[13] = tls;
> else
> -#endif
> childregs->gpr[2] = tls;
> }
>

Reviewed-by: Michal Suchanek <msuchanek@xxxxxxx>

Thanks

Michal