[PATCH 00/28] ata: optimize core code size on PATA only setups

From: Bartlomiej Zolnierkiewicz
Date: Tue Jan 28 2020 - 08:36:01 EST


Hi,

There have been reports in the past of libata core code size
being a problem in migration from deprecated IDE subsystem on
legacy PATA only systems, i.e.:

https://lore.kernel.org/linux-ide/db2838b7-4862-785b-3a1d-3bf09811340a@xxxxxxxxx/

This patchset re-organizes libata core code to exclude SATA
specific code from being built for PATA only setups.

The end result is up to 17% (by 17246 bytes, from 101787 bytes to
84541 bytes) smaller libata core code size (as measured for m68k
arch using atari_defconfig) on affected setups.

I've tested this patchset using pata_falcon driver under ARAnyM
emulator.


patches #1-9 are general fixes/cleanups done in the process of
making the patchset (there should be no inter-dependencies between
them except patch #9 which depends on patch #8)

patch #10 separates PATA timings code to libata-pata-timings.c file

patch #11 optimizes ata_ncq_enable() inline for PATA only setups

patches #12-22 separate SATA only code from libata-core.c file to
libata-core-sata.c one

patches #24-25 separate SATA only code from libata-scsi.c file to
libata-scsi-sata.c one

patches #26-28 separate SATA only code from libata-eh.c file to
libata-eh-sata.c one


Best regards,
--
Bartlomiej Zolnierkiewicz
Samsung R&D Institute Poland
Samsung Electronics


Bartlomiej Zolnierkiewicz (28):
ata: remove stale maintainership information from core code
ata: expose ncq_enable_prio sysfs attribute only on NCQ capable hosts
ata: make SATA_PMP option selectable only if any SATA host driver is
enabled
sata_promise: use ata_cable_sata()
ata: simplify ata_scsiop_inq_89()
ata: use COMMAND_LINE_SIZE for ata_force_param_buf[] size
ata: optimize struct ata_force_param size
ata: move EXPORT_SYMBOL_GPL()s close to exported code
ata: remove EXPORT_SYMBOL_GPL()s not used by modules
ata: separate PATA timings code from libata-core.c
ata: add CONFIG_SATA_HOST=n version of ata_ncq_enabled()
ata: start separating SATA specific code from libata-core.c
ata: move ata_do_link_spd_horkage() to libata-core-sata.c
ata: move ata_dev_config_ncq*() to libata-core-sata.c
ata: move sata_print_link_status() to libata-core-sata.c
ata: move sata_down_spd_limit() to libata-core-sata.c
ata: move *sata_set_spd*() to libata-core-sata.c
ata: move sata_link_{debounce,resume}() to libata-core-sata.c
ata: move sata_link_hardreset() to libata-core-sata.c
ata: move sata_link_init_spd() to libata-core-sata.c
ata: move ata_qc_complete_multiple() to libata-core-sata.c
ata: move sata_scr_*() to libata-core-sata.c
ata: move sata_deb_timing_*() to libata-core-sata.c
ata: start separating SATA specific code from libata-scsi.c
ata: move ata_sas_*() to libata-scsi-sata.c
ata: start separating SATA specific code from libata-eh.c
ata: move ata_eh_analyze_ncq_error() & co. to libata-core-sata.c
ata: move ata_eh_set_lpm() to libata-core-sata.c

drivers/ata/Kconfig | 61 ++
drivers/ata/Makefile | 3 +
drivers/ata/libata-core-sata.c | 1077 +++++++++++++++++++++
drivers/ata/libata-core.c | 1456 ++---------------------------
drivers/ata/libata-eh-sata.c | 349 +++++++
drivers/ata/libata-eh.c | 354 +------
drivers/ata/libata-pata-timings.c | 180 ++++
drivers/ata/libata-scsi-sata.c | 523 +++++++++++
drivers/ata/libata-scsi.c | 542 +----------
drivers/ata/libata-sff.c | 4 -
drivers/ata/libata.h | 69 +-
drivers/ata/sata_promise.c | 8 +-
drivers/scsi/Kconfig | 1 +
drivers/scsi/libsas/Kconfig | 1 +
include/linux/libata.h | 176 ++--
15 files changed, 2496 insertions(+), 2308 deletions(-)
create mode 100644 drivers/ata/libata-core-sata.c
create mode 100644 drivers/ata/libata-eh-sata.c
create mode 100644 drivers/ata/libata-pata-timings.c
create mode 100644 drivers/ata/libata-scsi-sata.c

--
2.24.1