Re: [PATCH] hostap: Adjust indentation in prism2_hostapd_add_sta

From: Kalle Valo
Date: Sun Jan 26 2020 - 10:36:41 EST


Nathan Chancellor <natechancellor@xxxxxxxxx> wrote:

> Clang warns:
>
> ../drivers/net/wireless/intersil/hostap/hostap_ap.c:2511:3: warning:
> misleading indentation; statement is not part of the previous 'if'
> [-Wmisleading-indentation]
> if (sta->tx_supp_rates & WLAN_RATE_5M5)
> ^
> ../drivers/net/wireless/intersil/hostap/hostap_ap.c:2509:2: note:
> previous statement is here
> if (sta->tx_supp_rates & WLAN_RATE_2M)
> ^
> 1 warning generated.
>
> This warning occurs because there is a space before the tab on this
> line. Remove it so that the indentation is consistent with the Linux
> kernel coding style and clang no longer warns.
>
> Fixes: ff1d2767d5a4 ("Add HostAP wireless driver.")
> Link: https://github.com/ClangBuiltLinux/linux/issues/813
> Signed-off-by: Nathan Chancellor <natechancellor@xxxxxxxxx>
> Reviewed-by: Nick Desaulniers <ndesaulniers@xxxxxxxxxx>

Patch applied to wireless-drivers-next.git, thanks.

b61156fba74f hostap: Adjust indentation in prism2_hostapd_add_sta

--
https://patchwork.kernel.org/patch/11299247/

https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches