Re: [PATCH v2] can: tcan4x5x: Turn on the power before parsing the config

[Dan Murphy]

Marc

On 1/2/20 6:38 AM, Marc Kleine-Budde wrote:
> On 12/10/19 5:32 PM, Dan Murphy wrote:
> > The parse config function now performs action on the device either
> > reading or writing and a reset.  If the regulator is managed it needs
> > to be turned on.  So turn on the regulator if available if the parsing
> > fails then turn off the regulator.
> Another BTW:
> Consider converting the switching of the vsup to runtime_pm.
>
> Yet another one:
> Why do you disable the clocks in the error path of tcan4x5x_can_probe(),
> but never enable them?
>
> > out_clk:
> > 	if (!IS_ERR(mcan_class->cclk)) {
> > 		clk_disable_unprepare(mcan_class->cclk);
> > 		clk_disable_unprepare(mcan_class->hclk);
> > 	}
> - please move the clock handling from the m_can.c to the individual
>    driver
> - please move the clock handling to runtime_pm in the individual driver
> - remove the obsolete m_can_class_get_clocks()
> - make runtime_pm mandatory

Ack to the above I have made these changes locally. Will submit next week.

Dan


> regards,
> Marc