Re: [PATCH] drm/msm: Fix error about comments within a comment block

From: Jordan Crouse
Date: Tue Jan 14 2020 - 11:00:10 EST


On Mon, Jan 13, 2020 at 02:04:46PM -0800, Douglas Anderson wrote:
> My compiler yells:
> .../drivers/gpu/drm/msm/adreno/adreno_gpu.c:69:27:
> error: '/*' within block comment [-Werror,-Wcomment]
>
> Let's fix.

grumble something about the road being paved with good intentions....

Reviewed-by: Jordan Crouse <jcrouse@xxxxxxxxxxxxxx>

> Fixes: 6a0dea02c2c4 ("drm/msm: support firmware-name for zap fw (v2)")
> Signed-off-by: Douglas Anderson <dianders@xxxxxxxxxxxx>
> ---
>
> drivers/gpu/drm/msm/adreno/adreno_gpu.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/msm/adreno/adreno_gpu.c b/drivers/gpu/drm/msm/adreno/adreno_gpu.c
> index c146c3b8f52b..7fd29829b2fa 100644
> --- a/drivers/gpu/drm/msm/adreno/adreno_gpu.c
> +++ b/drivers/gpu/drm/msm/adreno/adreno_gpu.c
> @@ -67,7 +67,7 @@ static int zap_shader_load_mdt(struct msm_gpu *gpu, const char *fwname,
> *
> * If the firmware-name property is found, we bypass the
> * adreno_request_fw() mechanism, because we don't need to handle
> - * the /lib/firmware/qcom/* vs /lib/firmware/* case.
> + * the /lib/firmware/qcom/... vs /lib/firmware/... case.
> *
> * If the firmware-name property is not found, for backwards
> * compatibility we fall back to the fwname from the gpulist
> --
> 2.25.0.rc1.283.g88dfdc4193-goog
>

--
The Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum,
a Linux Foundation Collaborative Project