Re: [PATCH v5 1/4] dt-bindings: power: add Amlogic secure power domains bindings

From: Jianxin Pan
Date: Mon Jan 13 2020 - 22:11:45 EST


HI Kevin,

Thanks for your review, I will put pwrc under secure-monitor node.

On 2020/1/14 7:37, Kevin Hilman wrote:
> Jianxin Pan <jianxin.pan@xxxxxxxxxxx> writes:
>
>> Add the bindings for the Amlogic Secure power domains, controlling the
>> secure power domains.
>>
>> The bindings targets the Amlogic A1 and C1 compatible SoCs, in which the
>> power domain registers are in secure world.
>>
>> Signed-off-by: Jianxin Pan <jianxin.pan@xxxxxxxxxxx>
>> ---
>> .../bindings/power/amlogic,meson-sec-pwrc.yaml | 37 ++++++++++++++++++++++
>> include/dt-bindings/power/meson-a1-power.h | 32 +++++++++++++++++++
>> 2 files changed, 69 insertions(+)
>> create mode 100644 Documentation/devicetree/bindings/power/amlogic,meson-sec-pwrc.yaml
>> create mode 100644 include/dt-bindings/power/meson-a1-power.h
>>
>> diff --git a/Documentation/devicetree/bindings/power/amlogic,meson-sec-pwrc.yaml b/Documentation/devicetree/bindings/power/amlogic,meson-sec-pwrc.yaml
>> new file mode 100644
>> index 00000000..2ed269f
>> --- /dev/null
>> +++ b/Documentation/devicetree/bindings/power/amlogic,meson-sec-pwrc.yaml
>> @@ -0,0 +1,37 @@
>> +# SPDX-License-Identifier: (GPL-2.0+ OR MIT)
>> +# Copyright (c) 2019 Amlogic, Inc
>> +# Author: Jianxin Pan <jianxin.pan@xxxxxxxxxxx>
>> +%YAML 1.2
>> +---
>> +$id: "http://devicetree.org/schemas/power/amlogic,meson-sec-pwrc.yaml#";
>> +$schema: "http://devicetree.org/meta-schemas/core.yaml#";
>> +
>> +title: Amlogic Meson Secure Power Domains
>> +
>> +maintainers:
>> + - Jianxin Pan <jianxin.pan@xxxxxxxxxxx>
>> +
>> +description: |+
>> + Meson Secure Power Domains used in A1/C1 SoCs.
>> +
>> +properties:
>> + compatible:
>> + enum:
>> + - amlogic,meson-a1-pwrc
>> +
>> + "#power-domain-cells":
>> + const: 1
>> +
>> +required:
>> + - compatible
>> + - "#power-domain-cells"
>> +
>> +examples:
>> + - |
>> + pwrc: power-controller {
>> + compatible = "amlogic,meson-a1-pwrc";
>> + #power-domain-cells = <1>;
>> + secure-monitor = <&sm>;
>
> As requested by Rob, please put this under the secure-monitor node.
>
> Kevin
>
> .
>