Re: [PATCH v2] KVM: nVMX: vmread should not set rflags to specify success in case of #PF

From: linmiaohe
Date: Mon Jan 13 2020 - 21:15:33 EST


Hi,
On Mon, Jan 13, 2020 at 12:09:42PM -0800, Sean Christopherson wrote:
> > On Sat, Dec 28, 2019 at 02:25:24PM +0800, linmiaohe wrote:
> > > From: Miaohe Lin <linmiaohe@xxxxxxxxxx>
> > >
> > > In case writing to vmread destination operand result in a #PF,
> > vmread should not call nested_vmx_succeed() to set rflags to specify success.
> > > Similar to as done in VMPTRST (See handle_vmptrst()).
> > >
> > > Reviewed-by: Liran Alon <liran.alon@xxxxxxxxxx>
> > > Signed-off-by: Miaohe Lin <linmiaohe@xxxxxxxxxx>
> >
> > Reviewed-by: Sean Christopherson <sean.j.christopherson@xxxxxxxxx>
>
> Gah, got trigger happy. This could also have "Cc: stable@xxxxxxxxxxxxxxx".
> With that, my Reviewed-by stands :-).

Many thanks for your review. I would add Cc tag and resend a v3. Thanks again.