RE: [PATCH] cpu-topology: Skip the exist but not possible cpu nodes

From: Zengtao (B)
Date: Fri Jan 10 2020 - 21:04:15 EST


> -----Original Message-----
> From: Sudeep Holla [mailto:sudeep.holla@xxxxxxx]
> Sent: Friday, January 10, 2020 7:16 PM
> To: Zengtao (B)
> Cc: Linuxarm; Greg Kroah-Hartman; Rafael J. Wysocki;
> linux-kernel@xxxxxxxxxxxxxxx; Sudeep Holla
> Subject: Re: [PATCH] cpu-topology: Skip the exist but not possible cpu
> nodes
>
> On Wed, Jan 08, 2020 at 01:57:34AM +0000, Zengtao (B) wrote:
> [...]
>
> > I have the same concern, I have tried to find out some other return
> values
> > But seems not good enough.
> > Maybe it's better to introduce a new function to replace
> of_cpu_node_to_id
> > Any good suggestion?
> >
>
> No I don't have any. So please drop the extra logic, add a comment on
> -ENODEV return value and use it as needed.

OK, I will address the review comments and send v2.
Thanks

Zengtao