Re: [PATCH] fpga: xilinx-pr-decoupler: Remove clk_get error message for probe defer

From: Moritz Fischer
Date: Fri Jan 10 2020 - 15:53:18 EST


On Fri, Jan 10, 2020 at 12:01:13PM +0530, Nava kishore Manne wrote:
> From: Shubhrajyoti Datta <shubhrajyoti.datta@xxxxxxxxxx>
>
> In probe, the driver checks for devm_clk_get return and print error
> message in the failing case. However for -EPROBE_DEFER this message
> is confusing so avoid it.
>
> Signed-off-by: Shubhrajyoti Datta <shubhrajyoti.datta@xxxxxxxxxx>
> Signed-off-by: Michal Simek <michal.simek@xxxxxxxxxx>
> ---
> drivers/fpga/xilinx-pr-decoupler.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/fpga/xilinx-pr-decoupler.c b/drivers/fpga/xilinx-pr-decoupler.c
> index af9b387c56d3..7d69af230567 100644
> --- a/drivers/fpga/xilinx-pr-decoupler.c
> +++ b/drivers/fpga/xilinx-pr-decoupler.c
> @@ -101,7 +101,8 @@ static int xlnx_pr_decoupler_probe(struct platform_device *pdev)
>
> priv->clk = devm_clk_get(&pdev->dev, "aclk");
> if (IS_ERR(priv->clk)) {
> - dev_err(&pdev->dev, "input clock not found\n");
> + if (PTR_ERR(priv->clk) != -EPROBE_DEFER)
> + dev_err(&pdev->dev, "input clock not found\n");
> return PTR_ERR(priv->clk);
> }
>
> --
> 2.18.0
>
Applied to for-next,

Thanks