Re: [PATCH] sched/fair : Improve update_sd_pick_busiest for spare capacity case

From: Peter Zijlstra
Date: Wed Jan 08 2020 - 06:43:29 EST


On Fri, Dec 20, 2019 at 12:04:53PM +0100, Vincent Guittot wrote:
> Similarly to calculate_imbalance() and find_busiest_group(), using the
> number of idle CPUs when there is only 1 CPU in the group is not efficient
> because we can't make a difference between a CPU running 1 task and a CPU
> running dozens of small tasks competing for the same CPU but not enough
> to overload it. More generally speaking, we should use the number of
> running tasks when there is the same number of idle CPUs in a group instead
> of blindly select the 1st one.
>
> When the groups have spare capacity and the same number of idle CPUs, we
> compare the number of running tasks to select the busiest group.
>
Thanks!