Re: EDAC driver for DMC520

From: Scott Branden
Date: Tue Jan 07 2020 - 14:13:28 EST


Hi Shiping,

On 2020-01-07 11:01 a.m., Shiping Ji wrote:
On 1/7/2020 10:55 AM, Scott Branden wrote:
Lei/Shiping,

On 2020-01-07 10:49 a.m., Borislav Petkov wrote:
On Tue, Jan 07, 2020 at 09:57:26AM -0800, Scott Branden wrote:
Hello EDAC Maintainers,

Could somebody have a look at the DMC520 patch series that has been waiting
for a response since November:
https://patchwork.kernel.org/patch/11248785/
Well, the dt bindings stuff is still being discussed:

https://patchwork.kernel.org/patch/11248783/
Shiping, you also need to address the binding comment here.

Also, looking at this again, the patch authorship looks really fishy:

Sender is

From: Shiping Ji <shiping.linux@xxxxxxxxx>

however, he doesn't have his SOB in there and previous iterations were
done with Lei Wang whose SOB *is* there so I dunno what's going on.

*Especially* if Lei Wang is being added as a maintainer of that driver
by the second patch but he's not sending this driver himself. If this
driver is going to be orphaned the moment it lands upstream, I'm not
going to take it.
Shiping/Lei could you please provide appropriate signed-off-by?
Also, if you do not have an appropriate maintainer for the driver
we have Yuqing Shen who can be maintainer of this driver.
Yes, signed-off-by is still Lei Wang, who is still the official maintainer of the driver.

Lei is currently in sick leave so I'm trying to complete the patches on her behalf. Please kindly let me know how to add my SOB there.
If Lei is coming back soon then it may be best to wait for her?

Either way, I highly suggest you read the kernel documentation on submitting patches in the source tree:
Documentation/process/submitting-patches.rst.

Also, some of your other coworkers must know how to upstream code and can help you follow the process?
Thanks!

So at least those two things need to be fixed/clarified first.

HTH.