Re: [PATCH] gianfar: Solve ethernet TX/RX problems for ls1021a

From: Fabio Estevam
Date: Tue Jan 07 2020 - 09:17:36 EST


On Tue, Jan 7, 2020 at 11:13 AM Andrew Lunn <andrew@xxxxxxx> wrote:
>
> > diff --git a/drivers/net/ethernet/freescale/gianfar.c b/drivers/net/ethernet/freescale/gianfar.c
> > index 72868a28b621..ab4e45199df9 100644
> > --- a/drivers/net/ethernet/freescale/gianfar.c
> > +++ b/drivers/net/ethernet/freescale/gianfar.c
> > @@ -833,6 +833,7 @@ static int gfar_of_init(struct platform_device *ofdev, struct net_device **pdev)
> >
> > /* Find the TBI PHY. If it's not there, we don't support SGMII */
> > priv->tbi_node = of_parse_phandle(np, "tbi-handle", 0);
> > + priv->dma_endian_le = of_property_read_bool(np, "fsl,dma-endian-le");
>
> Hi Johnson
>
> You need to document this new property in the binding.

Yes, but what about calling it 'little-endian' which is commonly used
in arch/arm64/boot/dts/freescale/fsl-lsxxx device trees?