Re: [Linux-stm32] [PATCH net] net: stmmac: Fixed link does not need MDIO Bus

[Patrice CHOTARD]

Hi All

On 1/7/20 1:51 PM, Sriram Dash wrote:
>> From: Jose Abreu <Jose.Abreu@xxxxxxxxxxxx>
>> Subject: [PATCH net] net: stmmac: Fixed link does not need MDIO Bus
>>
>> When using fixed link we don't need the MDIO bus support.
>>
>> Reported-by: Heiko Stuebner <heiko@xxxxxxxxx>
>> Reported-by: kernelci.org bot <bot@xxxxxxxxxxxx>
>> Fixes: d3e014ec7d5e ("net: stmmac: platform: Fix MDIO init for platforms
>> without PHY")
>> Signed-off-by: Jose Abreu <Jose.Abreu@xxxxxxxxxxxx>
> Acked-by: Sriram Dash <Sriram.dash@xxxxxxxxxxx>

Tested on STiH410-B2260 board

Tested-by: Patrice Chotard <patrice.chotard@xxxxxx>

Thanks

>> ---
>> Cc: Giuseppe Cavallaro <peppe.cavallaro@xxxxxx>
>> Cc: Alexandre Torgue <alexandre.torgue@xxxxxx>
>> Cc: Jose Abreu <joabreu@xxxxxxxxxxxx>
>> Cc: "David S. Miller" <davem@xxxxxxxxxxxxx>
>> Cc: Maxime Coquelin <mcoquelin.stm32@xxxxxxxxx>
>> Cc: netdev@xxxxxxxxxxxxxxx
>> Cc: linux-stm32@xxxxxxxxxxxxxxxxxxxxxxxxxxxx
>> Cc: linux-arm-kernel@xxxxxxxxxxxxxxxxxxx
>> Cc: linux-kernel@xxxxxxxxxxxxxxx
>> Cc: Heiko Stuebner <heiko@xxxxxxxxx>
>> Cc: kernelci.org bot <bot@xxxxxxxxxxxx>
>> Cc: Florian Fainelli <f.fainelli@xxxxxxxxx>
>> Cc: Sriram Dash <sriram.dash@xxxxxxxxxxx>
>> ---
>>  drivers/net/ethernet/stmicro/stmmac/stmmac_platform.c | 2 +-
>>  1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/drivers/net/ethernet/stmicro/stmmac/stmmac_platform.c
>> b/drivers/net/ethernet/stmicro/stmmac/stmmac_platform.c
>> index cc8d7e7bf9ac..4775f49d7f3b 100644
>> --- a/drivers/net/ethernet/stmicro/stmmac/stmmac_platform.c
>> +++ b/drivers/net/ethernet/stmicro/stmmac/stmmac_platform.c
>> @@ -320,7 +320,7 @@ static int stmmac_mtl_setup(struct platform_device
>> *pdev,  static int stmmac_dt_phy(struct plat_stmmacenet_data *plat,
>>  			 struct device_node *np, struct device *dev)  {
>> -	bool mdio = false;
>> +	bool mdio = !of_phy_is_fixed_link(np);
>>  	static const struct of_device_id need_mdio_ids[] = {
>>  		{ .compatible = "snps,dwc-qos-ethernet-4.10" },
>>  		{},
>> --
>> 2.7.4
>
> _______________________________________________
> Linux-stm32 mailing list
> Linux-stm32@xxxxxxxxxxxxxxxxxxxxxxxxxxxx
> https://st-md-mailman.stormreply.com/mailman/listinfo/linux-stm32