Re: [PATCH] pinctrl: artpec6: fix __iomem on reg in set

From: Linus Walleij
Date: Tue Jan 07 2020 - 04:39:48 EST


On Wed, Dec 18, 2019 at 6:32 PM Ben Dooks <ben.dooks@xxxxxxxxxxxxxxx> wrote:
> On 18/12/2019 16:26, Jesper Nilsson wrote:
> > On Wed, Dec 18, 2019 at 11:16:02AM +0100, Ben Dooks (Codethink) wrote:

> >> - unsigned int *reg;
> >> + unsigned int __iomem *reg;
> >
> > void __iomem *reg;
> >
> > We're using as an argument to readl()?
>
> yes, readl() shoud take an __iomem attributed pointer.

Shall I change it to void as well when applying?

Yours,
Linus Walleij