Re: [PATCH v3 bpf-next 08/11] libbpf: add libbpf support to batch ops

From: Brian Vazquez
Date: Tue Jan 07 2020 - 01:52:04 EST


Thanks for reviewing it, Andrii!

On Wed, Dec 18, 2019 at 6:54 PM Andrii Nakryiko
<andrii.nakryiko@xxxxxxxxx> wrote:
>
> On Wed, Dec 11, 2019 at 2:35 PM Brian Vazquez <brianvv@xxxxxxxxxx> wrote:
> >
> > From: Yonghong Song <yhs@xxxxxx>
> >
> > Added four libbpf API functions to support map batch operations:
> > . int bpf_map_delete_batch( ... )
> > . int bpf_map_lookup_batch( ... )
> > . int bpf_map_lookup_and_delete_batch( ... )
> > . int bpf_map_update_batch( ... )
> >
> > Signed-off-by: Yonghong Song <yhs@xxxxxx>
> > ---
>
> These libbpf APIs should use _opts approach from the get go to make
> them extensible, but preserving backwards/forward compatibility.
> Please take a look at one of few that are already using them (or
> follow Andrey's bpf_prog_attach work, as he's adding opts-based one at
> the moment).

I will add this to next version.
>
> > tools/lib/bpf/bpf.c | 61 ++++++++++++++++++++++++++++++++++++++++
> > tools/lib/bpf/bpf.h | 14 +++++++++
> > tools/lib/bpf/libbpf.map | 4 +++
> > 3 files changed, 79 insertions(+)
> >
>
> [...]