Re: [PATCH] security: selinux: allow per-file labelling for binderfs

From: Paul Moore
Date: Mon Jan 06 2020 - 21:13:57 EST


On Mon, Jan 6, 2020 at 2:33 PM Stephen Smalley <sds@xxxxxxxxxxxxx> wrote:
> On 1/6/20 2:06 PM, Hridya Valsaraju wrote:
> > On Mon, Jan 6, 2020 at 10:33 AM 'Stephen Smalley' via kernel-team
> > <kernel-team@xxxxxxxxxxx> wrote:
> >>
> >> On 1/6/20 1:13 PM, Hridya Valsaraju wrote:
> >>> This patch allows genfscon per-file labeling for binderfs.
> >>> This is required to have separate permissions to allow
> >>> access to binder, hwbinder and vndbinder devices which are
> >>> relocating to binderfs.
> >>>
> >>> Acked-by: Jeff Vander Stoep <jeffv@xxxxxxxxxx>
> >>> Acked-by: Mark Salyzyn <salyzyn@xxxxxxxxxxx>
> >>> Signed-off-by: Hridya Valsaraju <hridya@xxxxxxxxxx>
> >>
> >> Do you want binderfs to also support userspace labeling of files via
> >> setxattr()? If so, you'll want to also add it to
> >> selinux_is_genfs_special_handling() as well.
> >
> > Thank you for the quick response Stephen :) I cannot think of a
> > use-case for the userspace labelling of files in binderfs via
> > setxattr() as of now. I
> > will make the change if one comes up!
>
> Ok, then you can include my:
> Acked-by: Stephen Smalley <sds@xxxxxxxxxxxxx>

Merged into selinux/next, thanks everyone!

--
paul moore
www.paul-moore.com