Re: [PATCH v2 0/3] smp: Allow smp_call_function_single_async() to insert locked csd

From: Peter Xu
Date: Mon Jan 06 2020 - 11:40:38 EST


Ping - Would anyone like to review/pick this series?

Peter, is this series ok for you?

Thanks,

On Mon, Dec 16, 2019 at 04:31:22PM -0500, Peter Xu wrote:
> This v2 introduced two more patches to let mips/kernel/smp.c and
> kernel/sched/core.c to start using the new feature, then we can drop
> the customized implementations.
>
> One thing to mention is that cpuidle_coupled_poke_pending is another
> candidate that we can consider, however that cpumask is special in
> that it's not only used for singleton test of the per-vcpu csd when
> injecting new calls, but also in cpuidle_coupled_any_pokes_pending()
> or so to check whether there's any pending pokes. In that sense it
> should be good to still keep the mask because it could be faster than
> looping over each per-cpu csd.
>
> Patch 1 is the same as v1, no change. Patch 2-3 are new ones.
>
> Smoke tested on x86_64 only.
>
> Please review, thanks.
>
> Peter Xu (3):
> smp: Allow smp_call_function_single_async() to insert locked csd
> MIPS: smp: Remove tick_broadcast_count
> sched: Remove rq.hrtick_csd_pending
>
> arch/mips/kernel/smp.c | 8 +-------
> kernel/sched/core.c | 9 ++-------
> kernel/sched/sched.h | 1 -
> kernel/smp.c | 14 +++++++++++---
> 4 files changed, 14 insertions(+), 18 deletions(-)
>
> --
> 2.23.0
>

--
Peter Xu