[PATCH] iwlwifi: remove object duplication in Makefile
From: Masahiro Yamada
Date: Mon Jan 06 2020 - 02:55:33 EST
The objects in $(iwlwifi-objs) $(iwlwifi-y) $(iwlwifi-m) are linked to
iwlwifi.ko .
This line adds $(iwlwifi-m) to iwlwifi-objs, so the objects from
$(iwlwifi-m) are listed twice as the dependency of the module.
It works because Kbuild trims the duplicated objects from linking,
but there is no good reason to have this line.
Signed-off-by: Masahiro Yamada <masahiroy@xxxxxxxxxx>
---
drivers/net/wireless/intel/iwlwifi/Makefile | 2 --
1 file changed, 2 deletions(-)
diff --git a/drivers/net/wireless/intel/iwlwifi/Makefile b/drivers/net/wireless/intel/iwlwifi/Makefile
index 0aae3fa4128c..a018d27a5410 100644
--- a/drivers/net/wireless/intel/iwlwifi/Makefile
+++ b/drivers/net/wireless/intel/iwlwifi/Makefile
@@ -19,8 +19,6 @@ iwlwifi-$(CONFIG_IWLMVM) += fw/paging.o fw/smem.o fw/init.o
iwlwifi-$(CONFIG_ACPI) += fw/acpi.o
iwlwifi-$(CONFIG_IWLWIFI_DEBUGFS) += fw/debugfs.o
-iwlwifi-objs += $(iwlwifi-m)
-
iwlwifi-$(CONFIG_IWLWIFI_DEVICE_TRACING) += iwl-devtrace.o
ccflags-y += -I$(src)
--
2.17.1