Re: [PATCH v2 6/6] x86/mce: Dynamically register default MCE handler

From: Luck, Tony
Date: Fri Jan 03 2020 - 14:46:33 EST


On Fri, Jan 03, 2020 at 04:07:22PM +0100, Jan H. SchÃnherr wrote:
> +retry:
> + if (has_notifiers)
> + blocking_notifier_chain_unregister(&x86_mce_decoder_chain,
> + &mce_default_nb);
> + else
> + blocking_notifier_chain_cond_register(&x86_mce_decoder_chain,
> + &mce_default_nb);

I get a compile error here:

CC arch/x86/kernel/cpu/mce/core.o
arch/x86/kernel/cpu/mce/core.c: In function âupdate_default_notifier_registrationâ:
arch/x86/kernel/cpu/mce/core.c:616:3: error: implicit declaration of function âblocking_notifier_chain_cond_registerâ; did you mean âblocking_notifier_chain_unregisterâ? [-Werror=implicit-function-declaration]
blocking_notifier_chain_cond_register(&x86_mce_decoder_chain,
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
blocking_notifier_chain_unregister

-Tony