Re: [PATCH 4.19 054/114] scsi: scsi_debug: num_tgts must be >= 0

From: Pavel Machek
Date: Fri Jan 03 2020 - 11:34:09 EST


Hi!

> From: Maurizio Lombardi <mlombard@xxxxxxxxxx>
>
> [ Upstream commit aa5334c4f3014940f11bf876e919c956abef4089 ]
>
> Passing the parameter "num_tgts=-1" will start an infinite loop that
> exhausts the system memory

Should we provide some kind of upper bound for num_tgts, too?
Otherwise integer overflow will follow later in the code. Even without
overflow, it will kill the system due to OOM...

Best regards,
Pavel

--
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html

Attachment: signature.asc
Description: Digital signature