Re: [PATCH] fpga: dfl: fme: remove set but not used variable 'fme'

From: Moritz Fischer
Date: Thu Jan 02 2020 - 23:49:28 EST


On Mon, Dec 30, 2019 at 09:51:40AM +0800, Wu Hao wrote:
> On Fri, Dec 27, 2019 at 02:57:26PM -0800, Moritz Fischer wrote:
> > On Thu, Dec 26, 2019 at 08:16:38PM +0800, yu kuai wrote:
> > > Fixes gcc '-Wunused-but-set-variable' warning:
> > >
> > > drivers/fpga/dfl-fme-main.c: In function âfme_dev_destroyâ:
> > > drivers/fpga/dfl-fme-main.c:678:18: warning: variable âfmeâ set but not
> > > used [-Wunused-but-set-variable]
> > >
> > > It is never used and so can be removed.
> > >
> > > Signed-off-by: yu kuai <yukuai3@xxxxxxxxxx>
> > > ---
> > > drivers/fpga/dfl-fme-main.c | 2 --
> > > 1 file changed, 2 deletions(-)
> > >
> > > diff --git a/drivers/fpga/dfl-fme-main.c b/drivers/fpga/dfl-fme-main.c
> > > index 7c930e6b314d..1d4690c99268 100644
> > > --- a/drivers/fpga/dfl-fme-main.c
> > > +++ b/drivers/fpga/dfl-fme-main.c
> > > @@ -675,10 +675,8 @@ static int fme_dev_init(struct platform_device *pdev)
> > > static void fme_dev_destroy(struct platform_device *pdev)
> > > {
> > > struct dfl_feature_platform_data *pdata = dev_get_platdata(&pdev->dev);
> > > - struct dfl_fme *fme;
> > >
> > > mutex_lock(&pdata->lock);
> > > - fme = dfl_fpga_pdata_get_private(pdata);
> > > dfl_fpga_pdata_set_private(pdata, NULL);
> > > mutex_unlock(&pdata->lock);
> > > }
> > > --
> > > 2.17.2
> > >
> > Acked-by: Moritz Fischer <mdf@xxxxxxxxxx>
>
> Acked-by: Wu Hao <hao.wu@xxxxxxxxx>
>
> Thanks
> Hao
>
> >
> > Thanks,
> > Moritz

Applied to for-next.

Thanks,
Moritz