RE: [PATCH v9 10/13] exfat: add nls operations

[Namjae Jeon]

> On Thursday 02 January 2020 16:20:33 Namjae Jeon wrote:
> > This adds the implementation of nls operations for exfat.
> >
> > Signed-off-by: Namjae Jeon <namjae.jeon@xxxxxxxxxxx>
> > Signed-off-by: Sungjong Seo <sj1557.seo@xxxxxxxxxxx>
> > ---
> >  fs/exfat/nls.c | 809
> > +++++++++++++++++++++++++++++++++++++++++++++++++
> >  1 file changed, 809 insertions(+)
> >  create mode 100644 fs/exfat/nls.c
> >
> > diff --git a/fs/exfat/nls.c b/fs/exfat/nls.c new file mode 100644
> > index 000000000000..af52328e28ff
> > --- /dev/null
> > +++ b/fs/exfat/nls.c
> > @@ -0,0 +1,809 @@
> > +// SPDX-License-Identifier: GPL-2.0-or-later
> > +/*
> > + * Copyright (C) 2012-2013 Samsung Electronics Co., Ltd.
> > + */
> > +
> > +#include <linux/string.h>
> > +#include <linux/nls.h>
> > +#include <linux/slab.h>
> > +#include <linux/buffer_head.h>
> > +#include <asm/unaligned.h>
> > +
> > +#include "exfat_raw.h"
> > +#include "exfat_fs.h"
> > +
> > +/* Upcase tabel macro */
> > +#define EXFAT_NUM_UPCASE	(2918)
> > +#define UTBL_COUNT		(0x10000)
> > +
> > +/*
> > + * Upcase table in compressed format (7.2.5.1 Recommended Up-case
> > +Table
> > + * in exfat specification, See:
> > +https://protect2.fireeye.com/url?k=25cbd240-78ac9666-25ca590f-0cc47a3
> > +1384a-776465f5f2917059&u=https://docs.microsoft.com/en-us/windows/
> > + * win32/fileio/exfat-specification).
> 
> Just a small suggestion: Do not wrap URLs as they are hard to copy-paste
> into web browser. Also my email client is not able to detect URL continue
> on next line...
Okay, Will fix it on next version.
Thanks for review!
> 
> > + */
> > +static const unsigned short uni_def_upcase[EXFAT_NUM_UPCASE] = {
> > +	0x0000, 0x0001, 0x0002, 0x0003, 0x0004, 0x0005, 0x0006, 0x0007,
> > +	0x0008, 0x0009, 0x000a, 0x000b, 0x000c, 0x000d, 0x000e, 0x000f,
> 
> ...
> 
> --
> Pali RohÃr
> pali.rohar@xxxxxxxxx