RE: [EXT] Re: [v2,net-next] enetc: add support time specific departure base on the qos etf

[Po Liu]

> -----Original Message-----
> From: David Miller <davem@xxxxxxxxxxxxx>
> Sent: 2019年12月31日 12:27
> To: Po Liu <po.liu@xxxxxxx>
> Cc: linux-kernel@xxxxxxxxxxxxxxx; netdev@xxxxxxxxxxxxxxx;
> vinicius.gomes@xxxxxxxxx; Claudiu Manoil <claudiu.manoil@xxxxxxx>;
> Vladimir Oltean <vladimir.oltean@xxxxxxx>; Alexandru Marginean
> <alexandru.marginean@xxxxxxx>; Xiaoliang Yang
> <xiaoliang.yang_1@xxxxxxx>; Roy Zang <roy.zang@xxxxxxx>; Mingkai Hu
> <mingkai.hu@xxxxxxx>; Jerry Huang <jerry.huang@xxxxxxx>; Leo Li
> <leoyang.li@xxxxxxx>; ivan.khoronzhuk@xxxxxxxxxx
> Subject: [EXT] Re: [v2,net-next] enetc: add support time specific departure base
> on the qos etf
> 
> Caution: EXT Email
> 
> From: Po Liu <po.liu@xxxxxxx>
> Date: Fri, 27 Dec 2019 03:12:18 +0000
> 
> > v2:
> > - fix the csum and time specific deaprture return directly if both
> > offloading enabled
> 
> The test is in the wrong location.
> 
> You are testing at run time when packets are being transmitted.
> 
> Instead, you should test when the configuration change is made which creates
> the conflict, and disallow the configuration change in such a conflicting case.

Ok, thanks!

Br,
Po Liu