[PATCH] usb: hub: missing parentheses in USE_NEW_SCHEME

From: atmgnd
Date: Wed Jan 01 2020 - 08:27:13 EST


accroding to bd0e6c9#diff-28615d62e1250eadc353d804f49bc6d6, will try old en=
umeration
scheme first for high speed devices. for example, when a high speed device =
pluged in,
line 2720 should expand to 0 at the first time. USE_NEW_SCHEME(0, 0 || 0 ||=
1) =3D=3D=3D 0.
but it wrongly expand to 1(alway expand to 1 for high speed device), and ch=
ange
USE_NEW_SCHEME to USE_NEW_SCHEME((i) % 2 =3D=3D (int)(scheme)) may be bette=
r ?

Signed-off-by: atmgnd <atmgnd@xxxxxxxxxxx>
---
drivers/usb/core/hub.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/usb/core/hub.c b/drivers/usb/core/hub.c
index f229ad6952c0..7d17deca7021 100644
--- a/drivers/usb/core/hub.c
+++ b/drivers/usb/core/hub.c
@@ -2692,7 +2692,7 @@ static unsigned hub_is_wusb(struct usb_hub *hub)
#define SET_ADDRESS_TRIES 2
#define GET_DESCRIPTOR_TRIES 2
#define SET_CONFIG_TRIES (2 * (use_both_schemes + 1))
-#define USE_NEW_SCHEME(i, scheme) ((i) / 2 =3D=3D (int)scheme)
+#define USE_NEW_SCHEME(i, scheme) ((i) / 2 =3D=3D (int)(scheme))

#define HUB_ROOT_RESET_TIME 60 /* times are in msec */
#define HUB_SHORT_RESET_TIME 10
--
2.17.1

--b1_75cbd74c8b9beee31bf8ab7672b19bdd
Content-Type: text/x-patch; name="0001-usb-hub-missing-parentheses-in-USE_NEW_SCHEME.patch"
Content-Transfer-Encoding: base64
Content-Disposition: attachment; filename=0001-usb-hub-missing-parentheses-in-USE_NEW_SCHEME.patch

RnJvbSA4NWYwMWI4OWQwNTBhOTg4ZjRkOWZjNzgyMzJkZTQ3ZTc5M2M2YTdjIE1vbiBTZXAgMTcg
MDA6MDA6MDAgMjAwMQpGcm9tOiBhdG1nbmQgPGF0bWduZEBvdXRsb29rLmNvbT4KRGF0ZTogV2Vk
LCAxIEphbiAyMDIwIDIxOjI3OjEzICswODAwClN1YmplY3Q6IFtQQVRDSF0gdXNiOiBodWI6IG1p
c3NpbmcgcGFyZW50aGVzZXMgaW4gVVNFX05FV19TQ0hFTUUKCmFjY3JvZGluZyB0byBiZDBlNmM5
I2RpZmYtMjg2MTVkNjJlMTI1MGVhZGMzNTNkODA0ZjQ5YmM2ZDYsIHdpbGwgdHJ5IG9sZCBlbnVt
ZXJhdGlvbgpzY2hlbWUgZmlyc3QgZm9yIGhpZ2ggc3BlZWQgZGV2aWNlcy4gZm9yIGV4YW1wbGUs
IHdoZW4gYSBoaWdoIHNwZWVkIGRldmljZSBwbHVnZWQgaW4sCmxpbmUgMjcyMCBzaG91bGQgZXhw
YW5kIHRvIDAgYXQgdGhlIGZpcnN0IHRpbWUuIFVTRV9ORVdfU0NIRU1FKDAsIDAgfHwgMCB8fCAx
KSA9PT0gMC4KYnV0IGl0IHdyb25nbHkgZXhwYW5kIHRvIDEoYWx3YXkgZXhwYW5kIHRvIDEgZm9y
IGhpZ2ggc3BlZWQgZGV2aWNlKSwgYW5kIGNoYW5nZQpVU0VfTkVXX1NDSEVNRSB0byBVU0VfTkVX
X1NDSEVNRSgoaSkgJSAyID09IChpbnQpKHNjaGVtZSkpIG1heSBiZSBiZXR0ZXIgPwoKU2lnbmVk
LW9mZi1ieTogYXRtZ25kIDxhdG1nbmRAb3V0bG9vay5jb20+Ci0tLQogZHJpdmVycy91c2IvY29y
ZS9odWIuYyB8IDIgKy0KIDEgZmlsZSBjaGFuZ2VkLCAxIGluc2VydGlvbigrKSwgMSBkZWxldGlv
bigtKQoKZGlmZiAtLWdpdCBhL2RyaXZlcnMvdXNiL2NvcmUvaHViLmMgYi9kcml2ZXJzL3VzYi9j
b3JlL2h1Yi5jCmluZGV4IGYyMjlhZDY5NTJjMC4uN2QxN2RlY2E3MDIxIDEwMDY0NAotLS0gYS9k
cml2ZXJzL3VzYi9jb3JlL2h1Yi5jCisrKyBiL2RyaXZlcnMvdXNiL2NvcmUvaHViLmMKQEAgLTI2
OTIsNyArMjY5Miw3IEBAIHN0YXRpYyB1bnNpZ25lZCBodWJfaXNfd3VzYihzdHJ1Y3QgdXNiX2h1
YiAqaHViKQogI2RlZmluZSBTRVRfQUREUkVTU19UUklFUwkyCiAjZGVmaW5lIEdFVF9ERVNDUklQ
VE9SX1RSSUVTCTIKICNkZWZpbmUgU0VUX0NPTkZJR19UUklFUwkoMiAqICh1c2VfYm90aF9zY2hl
bWVzICsgMSkpCi0jZGVmaW5lIFVTRV9ORVdfU0NIRU1FKGksIHNjaGVtZSkJKChpKSAvIDIgPT0g
KGludClzY2hlbWUpCisjZGVmaW5lIFVTRV9ORVdfU0NIRU1FKGksIHNjaGVtZSkJKChpKSAvIDIg
PT0gKGludCkoc2NoZW1lKSkKIAogI2RlZmluZSBIVUJfUk9PVF9SRVNFVF9USU1FCTYwCS8qIHRp
bWVzIGFyZSBpbiBtc2VjICovCiAjZGVmaW5lIEhVQl9TSE9SVF9SRVNFVF9USU1FCTEwCi0tIAoy
LjE3LjEKCg==


--b1_75cbd74c8b9beee31bf8ab7672b19bdd--