Fw: usbcore missing parentheses in USE_NEW_SCHEME

From: atmgnd
Date: Wed Jan 01 2020 - 09:52:24 EST


This is a multi-part message in MIME format.
I think there is missing parentheses in macro USE_NEW_SCHEME, it should be:
#define USE_NEW_SCHEME(i, scheme) ((i) / 2 == (int)(scheme))

causes a fail wiht "device descriptor read/64, error -110" using my usb drive on vmware using usb 3.0 hub.
from https://github.com/torvalds/linux/commit/25244227158e1502062041365a439a54cb8fe673#diff-28615d62e1250eadc353d804f49bc6d6

someone changed USE_NEW_SCHEME, but without parentheses for second parameter. as result. in fuction use_new_scheme when old_scheme_first is 1, use_new_scheme will return 1 always(actullay is should return 0). it also make https://github.com/torvalds/linux/commit/bd0e6c9614b95352eb31d0207df16dc156c527fa#diff-28615d62e1250eadc353d804f49bc6d6 fails.

I cannot use git send-mail, there some issue with my network provider. patch below, :