Re: [PATCH 2/2] phy: Enable compile testing for some of drivers

From: Krzysztof Kozlowski
Date: Tue Dec 31 2019 - 03:21:38 EST


On Mon, Dec 30, 2019 at 12:10:51PM -0800, Florian Fainelli wrote:
> Hi Krzysztof,
>
> On 12/30/19 9:24 AM, Krzysztof Kozlowski wrote:
> > Some of the phy drivers can be compile tested to increase build
> > coverage.
> >
> > Signed-off-by: Krzysztof Kozlowski <krzk@xxxxxxxxxx>
>
> This looks fine, you could also consider adding a bunch of other
> Broadcom PHY drivers which are not currently under COMPILE_TEST, yet
> build fine:

I'll send a v2 with them as well. They seem to compile fine.

Best regards,
Krzysztof

>
> diff --git a/drivers/phy/broadcom/Kconfig b/drivers/phy/broadcom/Kconfig
> index d3d983c128ea..d56db6d375e1 100644
> --- a/drivers/phy/broadcom/Kconfig
> +++ b/drivers/phy/broadcom/Kconfig
> @@ -50,7 +50,7 @@ config PHY_BCM_NS_USB3
>
> config PHY_NS2_PCIE
> tristate "Broadcom Northstar2 PCIe PHY driver"
> - depends on OF && MDIO_BUS_MUX_BCM_IPROC
> + depends on (OF && MDIO_BUS_MUX_BCM_IPROC) || COMPILE_TEST
> select GENERIC_PHY
> default ARCH_BCM_IPROC
> help
> @@ -83,7 +83,7 @@ config PHY_BRCM_SATA
>
> config PHY_BRCM_USB
> tristate "Broadcom STB USB PHY driver"
> - depends on ARCH_BRCMSTB
> + depends on ARCH_BRCMSTB || COMPILE_TEST
> depends on OF
> select GENERIC_PHY
> select SOC_BRCMSTB
>