Re: [PATCH v3] infiniband: i40iw: fix a potential NULL pointer dereference

From: Markus Elfring
Date: Sat Dec 28 2019 - 14:50:45 EST


> in_dev_get may return a NULL object.

I would prefer a wording like âA null pointer can be returned by in_dev_get().â.


> The fix handles the situation
> by adding a check to avoid NULL pointer dereference on idev,
> as pick_local_ipaddrs does.

How do you think about the wording suggestion âThus add a corresponding check
so that a null pointer dereference will be avoided at this place.â?

Please add also the tag âFixesâ to your change description.

Regards,
Markus