Re: [PATCH RFC v4 00/13] virtio-mem: paravirtualized memory

From: David Hildenbrand
Date: Tue Dec 24 2019 - 04:29:43 EST




> Am 24.12.2019 um 08:04 schrieb teawater <teawaterz@xxxxxxxxxxxxxxxxx>:
>
> ïHi David,
>
> Thanks for your work.
>
> I Got following build fail if X86_64_ACPI_NUMA is n with rfc3 and rfc4:
> make -j8 bzImage
> GEN Makefile
> DESCEND objtool
> CALL /home/teawater/kernel/linux-upstream3/scripts/atomic/check-atomics.sh
> CALL /home/teawater/kernel/linux-upstream3/scripts/checksyscalls.sh
> CHK include/generated/compile.h
> CC drivers/virtio/virtio_mem.o
> /home/teawater/kernel/linux-upstream3/drivers/virtio/virtio_mem.c: In function âvirtio_mem_translate_node_idâ:
> /home/teawater/kernel/linux-upstream3/drivers/virtio/virtio_mem.c:478:10: error: implicit declaration of function âpxm_to_nodeâ [-Werror=implicit-function-declaration]
> node = pxm_to_node(node_id);
> ^~~~~~~~~~~
> cc1: some warnings being treated as errors
> /home/teawater/kernel/linux-upstream3/scripts/Makefile.build:265: recipe for target 'drivers/virtio/virtio_mem.o' failed
> make[3]: *** [drivers/virtio/virtio_mem.o] Error 1
> /home/teawater/kernel/linux-upstream3/scripts/Makefile.build:503: recipe for target 'drivers/virtio' failed
> make[2]: *** [drivers/virtio] Error 2
> /home/teawater/kernel/linux-upstream3/Makefile:1649: recipe for target 'drivers' failed
> make[1]: *** [drivers] Error 2
> /home/teawater/kernel/linux-upstream3/Makefile:179: recipe for target 'sub-make' failed
> make: *** [sub-make] Error 2
>

Thanks Hui,

So it has to be wrapped in an ifdef, thanks!

Cheers!