Re: [PATCH 1/1] drivers: misc: Add support for nCipher HSM devices

[Kim, David]

Hi Greg,

Thanks for the speedy replies. Yes, I will add more background information and make the quick formatting changes for a v2. We'll reply to your other email comments and get those resolved as well. I was trying to be terse but looks like I was too terse. I thought the changelog text should be brief and the cover letter would be more verbose?

Regards,
Dave

________________________________________
From: Greg KH <gregkh@xxxxxxxxxxxxxxxxxxx>
Sent: Tuesday, December 17, 2019 1:32 PM
To: Kim, David
Cc: arnd@xxxxxxxx; linux-kernel@xxxxxxxxxxxxxxx; Magee, Tim
Subject: Re: [PATCH 1/1] drivers: misc: Add support for nCipher HSM devices

On Tue, Dec 17, 2019 at 01:22:44PM +0000, Dave Kim wrote:
> ïFrom: David Kim <david.kim@xxxxxxxxxxx>
>
> Introduce the driver for nCipher's Solo and Solo XC range of PCIe hardware
> security modules (HSM), which provide key creation/management and
> cryptography services.

A bit more description of exactly _what_ these devices do would be
helpful.

Also, how does userspace interact with the driver?  What api(s) are you
using/creating?  What userspace tools work with the device?

In short, we need more than just a one sentance description to be able
to properly review the code and provide text for a user to know what to
do with this driver.

Can you fix all that up and send a v2?

thanks,

greg k-h