Re: [PATCH] x86/microcode: make stub function static inline

From: Borislav Petkov
Date: Wed Dec 11 2019 - 16:38:28 EST


On Thu, Dec 05, 2019 at 10:44:33PM -0500, Valdis KlÄtnieks wrote:
> When building with C=1 W=1, both sparse and gcc complain:
>
> CHECK arch/x86/kernel/cpu/microcode/core.c
> ./arch/x86/include/asm/microcode_amd.h:56:6: warning: symbol 'reload_ucode_amd' was not declared. Should it be static?
> CC arch/x86/kernel/cpu/microcode/core.o
> In file included from arch/x86/kernel/cpu/microcode/core.c:36:
> ./arch/x86/include/asm/microcode_amd.h:56:6: warning: no previous prototype for 'reload_ucode_amd' [-Wmissing-prototypes
> ]

Hmm, I don't see this with gcc 9.2 and sparse 0.6.1 here.

--
Regards/Gruss,
Boris.

https://people.kernel.org/tglx/notes-about-netiquette